Skip to content

feat(use): add --from-npm CLI flag#358

Open
aduh95 wants to merge 6 commits intomainfrom
from-npm
Open

feat(use): add --from-npm CLI flag#358
aduh95 wants to merge 6 commits intomainfrom
from-npm

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Jan 22, 2024

This implements the flag discussed in #354 (comment). This of course makes sense only if we add support for arbitrary URLs, but that's for another PR.

@aduh95 aduh95 marked this pull request as ready for review February 21, 2024 04:29
@aduh95 aduh95 requested review from arcanis and merceyz February 21, 2024 05:07
@arcanis
Copy link
Copy Markdown
Contributor

arcanis commented Feb 21, 2024

Syntax-wise, what do you think of instead supporting corepack use yarn@npm:..., similar to how deps can be aliased?

@@ -39,14 +39,21 @@ export abstract class BaseCommand extends Command<Context> {
const {data, indent} = nodeUtils.readPackageJson(content);

const previousPackageManager = data.packageManager ?? `unknown`;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little shaky but it's golden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants